KKcorps commented on code in PR #8674:
URL: https://github.com/apache/pinot/pull/8674#discussion_r922645687
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/IndexSegment.java:
##########
@@ -86,6 +87,15 @@ public interface IndexSegment {
*/
GenericRow getRecord(int docId, GenericRow reuse);
+ /**
+ * Returns the primaryKey for a given docId
+ *
+ * @param docId Document Id
+ * @param reuse Reusable buffer for the primary key
+ * @return Primary key for the given document Id
+ */
+ void getPrimaryKey(int docId, PrimaryKey reuse);
Review Comment:
I think we should keep this as reuse only since buffer has slightly
different connotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
