xiangfu0 commented on code in PR #9089:
URL: https://github.com/apache/pinot/pull/9089#discussion_r927359034
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -573,12 +574,13 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
streamMessageCount++;
}
updateCurrentDocumentCountMetrics();
- if (streamMessageCount != 0) {
Review Comment:
Also will this behavior change metrics reporting
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -573,12 +574,13 @@ private void processStreamEvents(MessageBatch
messagesAndOffsets, long idlePipeS
streamMessageCount++;
}
updateCurrentDocumentCountMetrics();
- if (streamMessageCount != 0) {
Review Comment:
Does the behavior consistent for other streaming solutions like kinesis?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
