somandal opened a new pull request, #9117: URL: https://github.com/apache/pinot/pull/9117
Emit a metric to identify whether Selection OrderBy queries have any multi-value columns as part of the order by clause (either as an identifier or via a transform). The original PR https://github.com/apache/pinot/pull/9078 gives details about the issue we are trying to catch with this metric. As discussed on the original PR, we decide to emit a metric first, monitor the applications that use Pinot and then make the proper fix to throw an exception for any Selection OrderBy queries with multi-value columns present. This PR adds the metric via adding a new `MetadataKey` to the `DataTable`. The `QueryScheduler` then emits a metric if this `MetadataKey` is present and set to `true`. This mechanism is not ideal but is the only way we could find to emit this metric. Technically we do not need to send this data to the Broker side, nor do we need to do anything more than emit a metric for this case. The issue with updating the `MetadataKey` is now an extra enum field will be left behind and cannot be cleaned up for backward compatibility reasons. As a future PR we should consider changing the interfaces slightly to allow capturing some generic `metadata` which do not need to be sent to the Broker side. cc @siddharthteotia @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
