somandal commented on PR #9078:
URL: https://github.com/apache/pinot/pull/9078#issuecomment-1197369047

   > It is a good idea to first emit metrics, then after monitoring for some 
time, change it to throw exceptions. I'd suggest only changing the 
`SelectionOrderByOperator` because that is the correct place to handle this 
check.
   
   Hey @Jackie-Jiang, I've created a new PR: 
https://github.com/apache/pinot/pull/9117 to address the metrics change. Once 
we get that in and monitor the usage on our end for such queries, I'll get back 
to this fix and make the clean change in the `SelectionOrderByOperator` 
directly. Can you take a look at that metrics change when you get a chance? 
Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to