siddharthteotia commented on PR #9121: URL: https://github.com/apache/pinot/pull/9121#issuecomment-1198896285
> @siddharthteotia I'm raising this in place of #8961. Since the cardinality value needed when creating bloom filter is only required to be an estimate and not exact, I feel the dataSource changes in the previous PR just to get accurate cardinality for the non dictionary column would've been an overkill. Here we're just using total number of entries as the next best estimate instead. Please do have a look. > > cc: @Jackie-Jiang Ya that sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
