siddharthteotia commented on code in PR #9117:
URL: https://github.com/apache/pinot/pull/9117#discussion_r933440574
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java:
##########
@@ -101,10 +112,33 @@ protected InstanceResponseBlock getNextBlock() {
responseMetaData
.put(MetadataKey.SYSTEM_ACTIVITIES_CPU_TIME_NS.getName(),
String.valueOf(systemActivitiesCpuTimeNs));
+ // TODO: Remove this once the SelectionOrderByOperator is modified to
throw an exception to catch cases where
+ // an MV column (identifier or via transform) is present on the
order-by list
+ logAndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock);
+
return instanceResponseBlock;
} else {
- return new InstanceResponseBlock(getCombinedResults());
+ // TODO: Remove this once the SelectionOrderByOperator is modified to
throw an exception to catch cases where
+ // an MV column (identifier or via transform) is present on the
order-by list
+ IntermediateResultsBlock intermediateResultsBlock = getCombinedResults();
+ logAndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock);
Review Comment:
Suggest doing a bit of cleanup
- Move `IntermediateResultBlock` and `InstanceResponseBlock` declaration
before if-else block
- Call
logA`ndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock)`
outside if-else
- return `instanceResponseBlock` outside if-else
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java:
##########
@@ -101,10 +112,33 @@ protected InstanceResponseBlock getNextBlock() {
responseMetaData
.put(MetadataKey.SYSTEM_ACTIVITIES_CPU_TIME_NS.getName(),
String.valueOf(systemActivitiesCpuTimeNs));
+ // TODO: Remove this once the SelectionOrderByOperator is modified to
throw an exception to catch cases where
+ // an MV column (identifier or via transform) is present on the
order-by list
+ logAndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock);
+
return instanceResponseBlock;
} else {
- return new InstanceResponseBlock(getCombinedResults());
+ // TODO: Remove this once the SelectionOrderByOperator is modified to
throw an exception to catch cases where
+ // an MV column (identifier or via transform) is present on the
order-by list
+ IntermediateResultsBlock intermediateResultsBlock = getCombinedResults();
+ logAndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock);
Review Comment:
Suggest doing a bit of cleanup
- Move `IntermediateResultBlock` and `InstanceResponseBlock` declaration
before if-else block
- Call
logA`ndEmitMetricForQueryHasMVSelectionOrderBy(intermediateResultsBlock)`
outside if-else
- return `instanceResponseBlock` after if-else
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
