nizarhejazi commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r933669225
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function
thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 &&
functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
yes, it is never empty except in one test: testSqlWithFinalRowCountChecker
(part of pinot-query-runtime tests).
##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function
thriftFunction) {
for (Expression operand : operands) {
arguments.add(getExpression(operand));
}
+ if (arguments.size() == 0 &&
functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {
Review Comment:
yes, it is never empty except in one test: `testSqlWithFinalRowCountChecker`
(part of pinot-query-runtime tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
