[GitHub] [pinot] mneedham commented on a diff in pull request #9134: Add timestamp index fields to schema for the real-time ingestion path

[GitBox]

mneedham commented on code in PR #9134:
URL: https://github.com/apache/pinot/pull/9134#discussion_r935470631


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -636,7 +636,7 @@ private void 
setTimestampIndexExpressionOverrideHints(@Nullable Expression expre
             && timeExpression.getIdentifier() != null) {
           String timeColumn = timeExpression.getIdentifier().getName();
           String timeColumnWithGranularity = 
TimestampIndexGranularity.getColumnNameWithGranularity(timeColumn,
-              TimestampIndexGranularity.valueOf(granularString));
+              TimestampIndexGranularity.valueOf(granularString.toUpperCase()));

Review Comment:
   Yeh that makes sense. Have added a commit to do that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org