navina commented on code in PR #9148:
URL: https://github.com/apache/pinot/pull/9148#discussion_r936089638
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -417,7 +417,9 @@ public String alterTableStateOrListTableConfig(
@ApiOperation(value = "Deletes a table", notes = "Deletes a table")
public SuccessResponse deleteTable(
@ApiParam(value = "Name of the table to delete", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Retention period for the table segments (e.g. 12h,
3d); Using 0d or -1d will instantly "
Review Comment:
can you clarify if this retention period on the server or on the deep store?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -417,7 +417,9 @@ public String alterTableStateOrListTableConfig(
@ApiOperation(value = "Deletes a table", notes = "Deletes a table")
public SuccessResponse deleteTable(
@ApiParam(value = "Name of the table to delete", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Retention period for the table segments (e.g. 12h,
3d); Using 0d or -1d will instantly "
Review Comment:
Does this retention period in the query override any retention setting at
the table or controller config level ? Best to clarify the behavior.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -335,7 +335,7 @@ private long getDeletionTimeMsFromFile(String targetFile,
long lastModifiedTime)
}
@Nullable
- private static Long getRetentionMsFromTableConfig(@Nullable TableConfig
tableConfig) {
+ public static Long getRetentionMsFromTableConfig(@Nullable TableConfig
tableConfig) {
Review Comment:
is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
