Jackie-Jiang commented on code in PR #9150:
URL: https://github.com/apache/pinot/pull/9150#discussion_r936122528
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -44,16 +44,16 @@ public enum Strategy {
private final Mode _mode;
@JsonPropertyDescription("Function to hash the primary key.")
- private final HashFunction _hashFunction;
+ private HashFunction _hashFunction;
@JsonPropertyDescription("Partial update strategies.")
- private final Map<String, Strategy> _partialUpsertStrategies;
+ private Map<String, Strategy> _partialUpsertStrategies;
@JsonPropertyDescription("default upsert strategy for partial mode")
- private final Strategy _defaultPartialUpsertStrategy;
+ private Strategy _defaultPartialUpsertStrategy;
@JsonPropertyDescription("Column for upsert comparison, default to time
column")
- private final String _comparisonColumn;
+ private String _comparisonColumn;
@JsonCreator
Review Comment:
Remove this annotation and add `@Deprecated`
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java:
##########
@@ -77,6 +77,10 @@ public UpsertConfig(@JsonProperty(value = "mode", required =
true) Mode mode,
_hashFunction = hashFunction == null ? HashFunction.NONE : hashFunction;
}
+ public UpsertConfig(Mode mode) {
Review Comment:
Let's use an empty constructor which is required for the json deserialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
