Jackie-Jiang commented on PR #9186: URL: https://github.com/apache/pinot/pull/9186#issuecomment-1212829667
> Can the DedupManager be accomodated to implement this interface or should we do something else? IMO, it doesn't make sense to keep a seperate dedup config as as well as a seperate implementation with these changes. We may revisit the dedup after finishing the upsert improvement. IMO dedup won't share the same config or interface because they are different feature and trying to address different problems. The initial version of dedup shares a lot of code with upsert, but in the future we might want to handle them differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
