npawar commented on code in PR #9197:
URL: https://github.com/apache/pinot/pull/9197#discussion_r947039545
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -90,6 +90,23 @@ public Response resumeConsumption(
}
}
+ @POST
+ @Path("/tables/{tableName}/resetConsumption")
Review Comment:
+1 . we already have reset API which does helix disable/enable. this is
different in logic, so calling it forceCommit would avoid confusion
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -90,6 +90,23 @@ public Response resumeConsumption(
}
}
+ @POST
+ @Path("/tables/{tableName}/resetConsumption")
+ @ApiOperation(value = "Reset consumption of a realtime table",
+ notes = "Reset the consumption for a realtime table using force commit")
Review Comment:
Maybe add some note in the description about it being async, and 200
response may not mean it has actually been done already? Will there be a
followup to this to know status of resetConsumption (like the recent reload
status API)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
