navina commented on code in PR #9205:
URL: https://github.com/apache/pinot/pull/9205#discussion_r947298294
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/constant/ConstantMVForwardIndexReader.java:
##########
@@ -45,6 +45,9 @@ public DataType getStoredType() {
@Override
public int getDictIdMV(int docId, int[] dictIdBuffer,
ForwardIndexReaderContext context) {
+ if (dictIdBuffer.length == 0) {
Review Comment:
This looks like a code smell and is better to be more defensive. There is no
guarantee that a caller to this method knows how `maxNumberOfMultiValues`
influences the behavior of this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
