tanmesh commented on issue #9137: URL: https://github.com/apache/pinot/issues/9137#issuecomment-1222798281
Hey, I am planning to pick this task. I have a couple of follow-up questions from my investigations: Need a bit of context to understand the difference b/n GrpcBrokerRequestHandler, MultiStageBrokerRequestHandler and SingleConnectionBrokerRequestHandler which are invoked from [here](https://github.com/tanmesh/pinot/blob/fc696ceb4b9386f3023ed9911c88022e6e2fa152/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java#L571). Are we using all of them? At a high level, I am planning to: 1. Pass a limit down to [processBrokerRequest](https://github.com/tanmesh/pinot/blob/fc696ceb4b9386f3023ed9911c88022e6e2fa152/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java#L571) method after extracting it from the compiled pinot query. Note: limit would only be passed for early terminate cases (ie, select and select distinct without ORDER BY) 2. Return early from [offline server request](https://github.com/tanmesh/pinot/blob/fc696ceb4b9386f3023ed9911c88022e6e2fa152/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java#L96) after limit no of responses are received from offline servers or go to [real time servers](https://github.com/tanmesh/pinot/blob/fc696ceb4b9386f3023ed9911c88022e6e2fa152/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java#L101) to gather limit responses 3. No changes needed in [reduceOnStreamResponse](https://github.com/tanmesh/pinot/blob/fc696ceb4b9386f3023ed9911c88022e6e2fa152/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/GrpcBrokerRequestHandler.java#L104) as it would only have limit no of responses. Please let me know how the implementation proposal sounds and if I am missing something. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
