61yao commented on PR #9322: URL: https://github.com/apache/pinot/pull/9322#issuecomment-1238671107
> This might not be the best way to support literal equations let's first straighten out the target: > > ## do we want to support this on transform or predicate > I think let's focus on transform functions. in this case I think the missing piece is to add literal handling to `binaryoperatortransformfunction` on both side > > ## do we want to do typed equal / not-equal check > let's only do non-typed check. b/c typed solution will be very complex: see #8596 > > with the basic solution in we can focus on #8596 to actually make the literals typed. I am not sure if I fully understand about your point on literal support for binaryTransform. Shouldn't two literal eval fall into scalar function by default? Or you meant expressions like SELECT <BOOL_EXPR> = TRUE ? this is already supported. I am not against using proposal https://github.com/apache/pinot/issues/8596 depending on the priority. This PR is hacky and expensive. but I feel it is not worse than the implementation we already have right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
