yuanbenson commented on code in PR #9295:
URL: https://github.com/apache/pinot/pull/9295#discussion_r964300002
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java:
##########
@@ -371,4 +372,35 @@ private static File generateSegmentMetadataFile(PinotFS
fileSystem, URI tarFileU
FileUtils.deleteQuietly(segmentMetadataDir);
}
}
+
+ public static List<String>
getSegmentNames(BatchConfigProperties.SegmentPushType pushMode,
Review Comment:
Thanks @snleee! As discussed offline, after looking at
`SegmentPushUtils.java#getSegmentUriToTarPathMap` again, this separation based
on `pushMode` is indeed unnecessary as the URI names are derived from
tarFilePaths from `segmentsUriToTarPathMap.values()` anyways, which means TAR,
METADATA and URI can be unified.
Hence, removed the overrides and brought generic implementation up to the
base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
