zhtaoxiang commented on code in PR #9339:
URL: https://github.com/apache/pinot/pull/9339#discussion_r965323490
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1859,9 +1858,8 @@ public void deleteOfflineTable(String tableName,
@Nullable String retentionPerio
LOGGER.info("Deleting table {}: Removed segment lineage",
offlineTableName);
// Remove task related metadata
- MinionTaskMetadataUtils.deleteTaskMetadata(_propertyStore,
MinionConstants.MergeRollupTask.TASK_TYPE,
- offlineTableName);
- LOGGER.info("Deleting table {}: Removed merge rollup task metadata",
offlineTableName);
+ MinionTaskMetadataUtils.deleteTaskMetadata(_propertyStore,
offlineTableName);
+ LOGGER.info("Deleting table {}: Removed all task metadata",
offlineTableName);
Review Comment:
done
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1922,13 +1920,8 @@ public void deleteRealtimeTable(String tableName,
@Nullable String retentionPeri
LOGGER.info("Deleting table {}: Removed segment lineage",
realtimeTableName);
// Remove task related metadata
- MinionTaskMetadataUtils.deleteTaskMetadata(_propertyStore,
MinionConstants.MergeRollupTask.TASK_TYPE,
- realtimeTableName);
- LOGGER.info("Deleting table {}: Removed merge rollup task metadata",
realtimeTableName);
-
- MinionTaskMetadataUtils.deleteTaskMetadata(_propertyStore,
MinionConstants.RealtimeToOfflineSegmentsTask.TASK_TYPE,
- realtimeTableName);
- LOGGER.info("Deleting table {}: Removed merge realtime to offline
metadata", realtimeTableName);
+ MinionTaskMetadataUtils.deleteTaskMetadata(_propertyStore,
realtimeTableName);
+ LOGGER.info("Deleting table {}: Removed all task metadata",
realtimeTableName);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
