siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r965593691
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java:
##########
@@ -142,6 +145,8 @@ public PhysicalColumnIndexContainer(SegmentDirectory.Reader
segmentReader, Colum
// Single-value
if (metadata.isSorted()) {
// Sorted
+ // forwardIndexDisabled columns do not need to be handled here as
forward index cannot be disabled on a
Review Comment:
May be I am mis-reading the if-else block here. For an unsorted dict column
with inv index, are we ok with line 157 being executed with null
`fwdIndexBuffer` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
