somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r966205557
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -143,7 +143,7 @@ public class OfflineClusterIntegrationTest extends
BaseClusterIntegrationTestSet
private static final String MAX_NUM_MULTI_VALUES_MAP_KEY =
"maxNumMultiValuesMap";
// TODO: This might lead to flaky test, as this disk size is not
deterministic
// as it depends on the iteration order of a HashSet.
- private static final int DISK_SIZE_IN_BYTES = 20797128;
+ private static final int DISK_SIZE_IN_BYTES = 20843088;
Review Comment:
so I've added a metadata field in the column metadata which increases the
disk size. Also based on the comment here it looks like the size may change
depending on the iteration order of the `HashSet`. Let me know if you think I
should look into this deeper to compare the difference in size change.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -869,6 +871,25 @@ private static void validateFieldConfigList(@Nullable
List<FieldConfig> fieldCon
default:
break;
}
+
+ // Validate the forward index disabled compatibility if enabled for
this column
Review Comment:
done
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -869,6 +871,25 @@ private static void validateFieldConfigList(@Nullable
List<FieldConfig> fieldCon
default:
break;
}
+
+ // Validate the forward index disabled compatibility if enabled for
this column
+ Map<String, String> fieldConfigProperties =
fieldConfig.getProperties();
+ if (fieldConfigProperties != null) {
+ boolean forwardIndexDisabled =
Boolean.parseBoolean(fieldConfigProperties
+ .getOrDefault(FieldConfig.FORWARD_INDEX_DISABLED,
FieldConfig.DEFAULT_FORWARD_INDEX_DISABLED));
+ if (forwardIndexDisabled) {
+ Preconditions.checkState((noDictionaryColumns == null ||
!noDictionaryColumns.contains(columnName))
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
