somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r967706985
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/DefaultIndexCreatorProvider.java:
##########
@@ -88,17 +90,25 @@ public ForwardIndexCreator
newForwardIndexCreator(IndexCreationContext.Forward c
context.getMaxRowLengthInBytes());
}
} else {
- if (context.getFieldSpec().isSingleValueField()) {
- if (context.isSorted()) {
- return new
SingleValueSortedForwardIndexCreator(context.getIndexDir(),
context.getFieldSpec().getName(),
- context.getCardinality());
+ if (context.forwardIndexDisabled()) {
+ if (context.getFieldSpec().isSingleValueField()) {
+ return new SingleValueNoOpForwardIndexCreator();
Review Comment:
done, consolidated this into 1 class. will address removing this as a future
change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
