walterddr commented on code in PR #9374:
URL: https://github.com/apache/pinot/pull/9374#discussion_r969876370
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -146,7 +180,7 @@ class Literal implements RexExpression {
public Literal() {
}
- public Literal(FieldSpec.DataType dataType, SqlTypeName sqlTypeName,
@Nullable Object value) {
+ public Literal(FieldSpec.DataType dataType, @Nullable Object value) {
Review Comment:
good catch
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -106,6 +113,33 @@ static FieldSpec.DataType toDataType(RelDataType type) {
}
}
+ // POC Code. Will clean-up later.
+ static RexExpression handleSearch(RexCall rexCall) {
Review Comment:
we can create a new util class call `RexExpressionUtils` to handle special
SqlKinds
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -100,6 +100,12 @@ private Object[][] provideTestSqlAndRowCount() {
new Object[]{"SELECT a.col1, a.ts, b.col2, b.col3 FROM a JOIN b ON
a.col1 = b.col2 "
+ " WHERE a.col3 >= 0 AND a.col2 = 'alice' AND b.col3 >= 0", 3},
+ // Join query with IN and Not-IN clause. Table A's side of join will
return 9 rows and Table B's side will
+ // return 2 rows. Join will be only on col1=bar and since A will
return 3 rows with that value and B will return
+ // 1 row, the final output will have 3 rows.
+ new Object[]{"SELECT a.col1, b.col2 FROM a JOIN b ON a.col1 = b.col1 "
Review Comment:
can we add more test. `IN` and `NOT IN` with 0, 1, and more than 1 values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
