snleee commented on code in PR #9398:
URL: https://github.com/apache/pinot/pull/9398#discussion_r970354181
##########
pinot-broker/src/test/resources/log4j2.xml:
##########
@@ -22,14 +22,15 @@
<Configuration>
<Appenders>
<Console name="console" target="SYSTEM_OUT">
- <PatternLayout>
- <pattern>%d{HH:mm:ss.SSS} %c{1} - %m%n</pattern>
- </PatternLayout>
+ <PatternLayout pattern="%d{HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n"/>
Review Comment:
Do we have any kind of job that parses from the log outputs? (e.g.
compatibility test) Since this is backward incompatible, it may have an impact
if we ever parse the output logs from the tests.
I think that changing the pattern for test logs should be fine as long as we
don't read anywhere in our testing jobs on Github action. But, we should be
careful if it will change the production log pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
