somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r972389654
##########
pinot-core/src/main/java/org/apache/pinot/core/minion/RawIndexConverter.java:
##########
@@ -204,6 +204,11 @@ private void convertColumn(FieldSpec fieldSpec)
// Create the raw index
DataSource dataSource =
_originalImmutableSegment.getDataSource(columnName);
ForwardIndexReader reader = dataSource.getForwardIndex();
+ if (reader == null) {
Review Comment:
This is a refactoring change (since the original variable was named
`reader`). Is it alright if I do this as a follow up to keep this PR simpler? I
can check for this in a bunch of other files too then.
##########
pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java:
##########
@@ -296,6 +297,10 @@ private void convertOneColumn(IndexSegment segment, String
column, File newSegme
throws IOException {
DataSource dataSource = segment.getDataSource(column);
ForwardIndexReader reader = dataSource.getForwardIndex();
+ if (reader == null) {
Review Comment:
This is a refactoring change (since the original variable was named
`reader`). Is it alright if I do this as a follow up to keep this PR simpler? I
can check for this in a bunch of other files too then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
