navina commented on code in PR #9224:
URL: https://github.com/apache/pinot/pull/9224#discussion_r973939545
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/RowMetadata.java:
##########
@@ -31,6 +32,8 @@
@InterfaceAudience.Public
@InterfaceStability.Evolving
public interface RowMetadata {
+ GenericRow EMPTY_ROW = new GenericRow();
Review Comment:
I tried to remove `RowMetadata`. But it looks like it is being passed around
in other interfaces like `MutableSegment` .
I think it is fine to leave the interface as it will be convenient to
include in other interface APIs and also, possibly extend it. I am wondering if
there is a lot of value in distinguishing `RowMetadata` from a
`StreamMessage`'s metadata.
`RowMetadata` can refer to Pinot related row metadata (Ex. time at which a
record was indexed in Pinot) . Where as, `StreamMessageMetadata` continues to
simply hold the incoming record related metadata (ex. when record was ingested
into upstream, headers etc). Wdyt @npawar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
