Jackie-Jiang commented on code in PR #9413:
URL: https://github.com/apache/pinot/pull/9413#discussion_r982808852
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/ZKMetadataUtils.java:
##########
@@ -66,9 +88,16 @@ private static void updateSegmentZKMetadata(String
tableNameWithType, SegmentZKM
}
if (segmentMetadata.getTimeInterval() != null) {
- segmentZKMetadata.setStartTime(segmentMetadata.getStartTime());
- segmentZKMetadata.setEndTime(segmentMetadata.getEndTime());
- segmentZKMetadata.setTimeUnit(segmentMetadata.getTimeUnit());
+ long startTimeMs =
TimeUnit.MILLISECONDS.convert(segmentMetadata.getStartTime(),
segmentMetadata.getTimeUnit());
Review Comment:
(minor) start/end time can be easily read from the time interval without
converting again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
