walterddr commented on code in PR #9495:
URL: https://github.com/apache/pinot/pull/9495#discussion_r984028660
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/NullHandlingTransformFunctionTest.java:
##########
@@ -86,17 +86,18 @@ public class NullHandlingTransformFunctionTest {
protected final double[] _doubleSVValues = new double[NUM_ROWS];
protected final String[] _stringSVValues = new String[NUM_ROWS];
protected final byte[][] _bytesSVValues = new byte[NUM_ROWS][];
+ protected final boolean[] _nullValues = new boolean[NUM_ROWS];
protected Map<String, DataSource> _dataSourceMap;
protected ProjectionBlock _projectionBlock;
- protected static final int NULL_VALUE_MOD = 10;
Review Comment:
added test. previously this mod is multipler of NUM_ROWS (1000) thus always
result in a deterministic pattern. use random to test instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
