jasperjiaguo commented on code in PR #9499:
URL: https://github.com/apache/pinot/pull/9499#discussion_r984109483
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java:
##########
@@ -289,6 +291,9 @@ public void runJob() {
int numRows = dataTable.getNumberOfRows();
for (int rowId = 0; rowId < numRows; rowId++) {
+ if (rowId % MAX_ROWS_UPSERT_PER_INTERRUPTION_CHECK == 0 &&
Thread.interrupted()) {
+ throw new EarlyTerminationException();
Review Comment:
Yeah as discussed below, IIUC currently no one can really catch that error
in the code now. But in the future we need to add handling code here if this
thread is to be canceled explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
