agavra commented on code in PR #9496:
URL: https://github.com/apache/pinot/pull/9496#discussion_r984690818
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -151,6 +151,8 @@ private Object[][] provideTestSql() {
new Object[]{"SELECT * FROM b ORDER BY col1, col2 DESC LIMIT 3"},
new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 10"},
new Object[]{"SELECT * FROM a ORDER BY col1 LIMIT 20"},
+ new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 1, 2"},
+ new Object[]{"SELECT * FROM a ORDER BY col1, ts LIMIT 2 OFFSET 1"},
Review Comment:
thanks for the observation @siddharthteotia - that makes me think that
perhaps we should be doing the opposite and actually fail hard on queries where
it isn't supported?
cc @walterddr - since I was actively working on that for multistage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
