siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r988662603
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -143,6 +143,16 @@ public TableConfig(@JsonProperty(value = TABLE_NAME_KEY,
required = true) String
Preconditions.checkArgument(indexingConfig != null, "'tableIndexConfig'
must be configured");
Preconditions.checkArgument(customConfig != null, "'metadata' must be
configured");
+ if (fieldConfigList != null) {
+ for (FieldConfig fieldConfig : fieldConfigList) {
+ Map<String, String> fieldConfigProperties =
fieldConfig.getProperties();
+ if (fieldConfigProperties != null) {
+ boolean forwardIndexDisabled =
Boolean.parseBoolean(fieldConfigProperties.getOrDefault(
Review Comment:
not sure why is this code needed here. we don't seem to be using the return
value anywhere locally ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
