siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r988808846
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##########
@@ -363,6 +379,12 @@ protected boolean createColumnV1Indices(String column)
argument);
return false;
}
+ // TODO: Support creation of derived columns from forward index
disabled columns
+ if (!_segmentWriter.hasIndexFor(argument,
ColumnIndexType.FORWARD_INDEX)) {
+ LOGGER.warn("Skip creating derived column: {} because argument:
{} does not have a forward index", column,
Review Comment:
Throwing error is better to force the user to not create a `derivedColumn`
from `noForwardIndex` column until reload code path supports everything
(including derived column handling possibly) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
