KKcorps commented on code in PR #9511:
URL: https://github.com/apache/pinot/pull/9511#discussion_r990903032
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/ingestion/IngestionConfig.java:
##########
@@ -51,6 +51,10 @@ public class IngestionConfig extends BaseJsonConfig {
@JsonPropertyDescription("Configs related to skip any row which has error
and continue during ingestion")
private boolean _continueOnError;
+ @JsonPropertyDescription("If set to true, the records with
GenericRow.INCOMPLETE_RECORD_KEY will not be consumed."
+ + "This can be helpful if user only wants to see correct data in the
table")
Review Comment:
Based on internal discussions, this flag is removed from the schema. The
approach looks ugly and until pinot support virtual columns with actual data we
can keep it as same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
