jackjlli commented on code in PR #9559:
URL: https://github.com/apache/pinot/pull/9559#discussion_r991687687
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -24,8 +24,8 @@
public class QueryConfig {
public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
- public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
"pinot.query.runner.max.msg.size";
- public static final int DEFAULT_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
128 * 1024 * 1024;
+ public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_SIZE_BYTES =
"pinot.query.runner.max.msg.size.bytes";
Review Comment:
I guess this config hasn't been in use yet, right?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -24,8 +24,8 @@
public class QueryConfig {
public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
- public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
"pinot.query.runner.max.msg.size";
- public static final int DEFAULT_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
128 * 1024 * 1024;
+ public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_SIZE_BYTES =
"pinot.query.runner.max.msg.size.bytes";
Review Comment:
Also, since this PR doesn't only modify the integration test, can we add
some comments to the description section about this config change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
