ankitsultana commented on code in PR #9571:
URL: https://github.com/apache/pinot/pull/9571#discussion_r996062544
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -87,10 +88,18 @@ public MultiStageBrokerRequestHandler(PinotConfiguration
config, BrokerRoutingMa
}
_reducerHostname = reducerHostname;
_reducerPort = config.getProperty(QueryConfig.KEY_OF_QUERY_RUNNER_PORT,
QueryConfig.DEFAULT_QUERY_RUNNER_PORT);
+ long brokerTimeoutMs =
config.getProperty(CommonConstants.Broker.CONFIG_OF_BROKER_TIMEOUT_MS, -1L);
Review Comment:
Should we handle the case when broker timeout is configured to be less than
the query runner timeout? If someone only sets the broker timeout as 5s and
uses a default query-runner timeout (10s), Mailbox operators may dangle for an
additional 5s even though broker would have already hung up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
