walterddr commented on code in PR #9556:
URL: https://github.com/apache/pinot/pull/9556#discussion_r996171383
##########
pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java:
##########
@@ -92,7 +92,7 @@ public void setup() {
}
}
- @AfterClass
+ @AfterMethod
Review Comment:
in this case I think we should split this into before/after class and before
after method. it is super weird to have beforeclass then after method.
##########
pinot-plugins/pinot-file-system/pinot-gcs/src/test/java/org/apache/pinot/plugin/filesystem/GcsPinotFSTest.java:
##########
@@ -92,7 +92,7 @@ public void setup() {
}
}
- @AfterClass
+ @AfterMethod
Review Comment:
in this case I think we should split this into before/after class and
before/after method. it is super weird to have beforeclass then aftermethod.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
