walterddr commented on code in PR #9582:
URL: https://github.com/apache/pinot/pull/9582#discussion_r996352256
##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/rewriter/NonAggregationGroupByToDistinctQueryRewriter.java:
##########
@@ -57,6 +57,13 @@ public PinotQuery rewrite(PinotQuery pinotQuery) {
Set<String> selectIdentifiers =
CalciteSqlParser.extractIdentifiers(pinotQuery.getSelectList(), true);
Set<String> groupByIdentifiers =
CalciteSqlParser.extractIdentifiers(pinotQuery.getGroupByList(), true);
if (groupByIdentifiers.containsAll(selectIdentifiers)) {
+ // TODO: need to patch DistinctDataTableReducer to remove these
excessive columns
Review Comment:
Actually with the v2 engine extra logic. No need for any change in v1
rewrite.
In fact after the PR v2 engine guarantee the select/groupby list are the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
