npawar commented on code in PR #9598:
URL: https://github.com/apache/pinot/pull/9598#discussion_r997400518
##########
pinot-controller/src/main/java/org/apache/pinot/controller/util/TableTierReader.java:
##########
@@ -86,10 +91,23 @@ public TableTierDetails getTableTierDetails(String
tableNameWithType, @Nullable
List<String> expectedSegmentsOnServer = entry.getValue();
TableTierInfo tableTierInfo = serverToTableTierInfoMap.get(server);
for (String expectedSegment : expectedSegmentsOnServer) {
- tableTierDetails._segmentTiers.computeIfAbsent(expectedSegment, (k) ->
new HashMap<>()).put(server,
+ tableTierDetails._segmentCurrentTiers.computeIfAbsent(expectedSegment,
(k) -> new HashMap<>()).put(server,
(tableTierInfo == null) ? ERROR_RESP_NO_RESPONSE :
getSegmentTier(expectedSegment, tableTierInfo));
}
}
+ if (!includeTargetTier) {
Review Comment:
any downside of removing the flag and just making this the default behavior
to include target tier info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
