siddharthteotia commented on PR #9501: URL: https://github.com/apache/pinot/pull/9501#issuecomment-1281653061
Based on @kkrugler 's suggestion to explore library, I had asked @SabrinaZhaozyf to do some investigation along the following lines. - Do we think library will offer comprehensive IP processing functionality besides `subnet_contains` (which is the current focus of your PR but we want to add more more in future) ? - Suggest taking a look at IP related functions supported by Kusto / Presto / Snowflake / Postgres to get an idea of IP processing landscape - Do we think our impl can be simplified by using the library and be less error prone ? - Probably not a good idea to use the library if it only supports specific functionality. - Some systems support IP address as a data type (NETWORK_ADDRESS IIRC ). We don't want to go there (yet) but good to check once if using the library will force us down a particular approach @SabrinaZhaozyf , you may want to share any of your findings here for reference / discussion. @Jackie-Jiang @walterddr @xiangfu0 - both approaches are implemented here. Can we get consensus on how we move forward ? One thing is that we will have to overload this for different types. Have you seen a similar requirement ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
