walterddr commented on code in PR #9484: URL: https://github.com/apache/pinot/pull/9484#discussion_r998761956
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/InMemorySendingMailbox.java: ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.mailbox; + +import java.util.concurrent.BlockingQueue; +import java.util.concurrent.TimeUnit; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; + + +public class InMemorySendingMailbox implements SendingMailbox<TransferableBlock> { + private final BlockingQueue<TransferableBlock> _queue; + private final String _mailboxId; + + public InMemorySendingMailbox(String mailboxId, BlockingQueue<TransferableBlock> queue) { + _mailboxId = mailboxId; + _queue = queue; + } + + @Override + public String getMailboxId() { + return _mailboxId; + } + + @Override + public void send(TransferableBlock data) + throws UnsupportedOperationException { + try { + if (!_queue.offer( + data, InMemoryMailboxService.DEFAULT_CHANNEL_TIMEOUT_SECONDS, TimeUnit.SECONDS)) { + throw new RuntimeException(String.format("Timed out when sending block in mailbox=%s", _mailboxId)); + } + } catch (InterruptedException e) { + throw new RuntimeException("Interrupted trying to send data through the channel", e); + } + } + + @Override + public void complete() { Review Comment: it is guarantee that the last message is the EOS message which serves the purpose of marking it "closed/completed". this is probably also the reason why the close flag didn't set to volatile b/c the thread that process the EOS content is also the one that sets the flag (not the otherway around) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
