walterddr commented on code in PR #9597:
URL: https://github.com/apache/pinot/pull/9597#discussion_r998902556
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlockUtils.java:
##########
@@ -84,7 +83,8 @@ public static Object[] getRow(TransferableBlock
transferableBlock, int rowId) {
if (transferableBlock.isContainerBlock() && transferableBlock.getType() ==
BaseDataBlock.Type.ROW) {
return transferableBlock.getContainer().get(rowId);
} else {
- return
SelectionOperatorUtils.extractRowFromDataTable(transferableBlock.getDataBlock(),
rowId);
+ // TODO: optimize the roaring bitmap decoding to only be done once and
reused across all row retrieval.
+ return DataBlockUtils.extractRow(transferableBlock.getDataBlock(),
rowId);
Review Comment:
found a bug from #9618 this should fix it but not as efficient. need to
think how to reuse the roaring null bitmap without duplicate extracting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
