walterddr commented on code in PR #9627: URL: https://github.com/apache/pinot/pull/9627#discussion_r999808058
########## kubernetes/helm/pinot/README.md: ########## @@ -273,8 +273,8 @@ helm install --namespace "pinot-quickstart" --name kafka incubator/kafka --set #### Create Kafka topic ```bash -kubectl -n pinot-quickstart exec kafka-0 -- kafka-topics --zookeeper kafka-zookeeper:2181 --topic flights-realtime --create --partitions 1 --replication-factor 1 -kubectl -n pinot-quickstart exec kafka-0 -- kafka-topics --zookeeper kafka-zookeeper:2181 --topic flights-realtime-avro --create --partitions 1 --replication-factor 1 +kubectl -n pinot-quickstart exec kafka-0 -- kafka-topics.sh --bootstrap-server kafka-0:9092 --topic flights-realtime --create --partitions 1 --replication-factor 1 +kubectl -n pinot-quickstart exec kafka-0 -- kafka-topics.sh --bootstrap-server kafka-0:9092 --topic flights-realtime-avro --create --partitions 1 --replication-factor 1 Review Comment: @xiangfu0 ^ do we need to have 2 version of the README instruction for different kafka? AFAIK we have 0.9 and 2.x support previously. also do we still need to keep support for older version of kafka? and if so how long? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
