walterddr commented on code in PR #9630:
URL: https://github.com/apache/pinot/pull/9630#discussion_r1002516823
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/DistributedStagePlan.java:
##########
@@ -73,4 +74,9 @@ public void setServerInstance(ServerInstance serverInstance) {
public void setStageRoot(StageNode stageRoot) {
_stageRoot = stageRoot;
}
+
+ public String explain() {
+ return ExplainPlanStageVisitor.explainFrom(_metadataMap, _stageRoot,
_serverInstance);
Review Comment:
this shouldn't be used by this visitor pattern as there's nothing to visit
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/ExplainPlanStageVisitor.java:
##########
@@ -44,7 +44,7 @@
*/
public class ExplainPlanStageVisitor implements
StageNodeVisitor<StringBuilder, ExplainPlanStageVisitor.Context> {
- private final QueryPlan _queryPlan;
Review Comment:
why are we changing explain plan stage visitor? this should not be used by
distributed stage plan as it already doesn't contain the query plan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
