Jackie-Jiang commented on code in PR #9624:
URL: https://github.com/apache/pinot/pull/9624#discussion_r1003874978
##########
pinot-common/src/main/java/org/apache/pinot/common/messages/SegmentReloadMessage.java:
##########
@@ -34,19 +34,22 @@ public class SegmentReloadMessage extends Message {
public static final String RELOAD_SEGMENT_MSG_SUB_TYPE = "RELOAD_SEGMENT";
private static final String FORCE_DOWNLOAD_KEY = "forceDownload";
+ private static final String SEGMENT_NAMES = "segmentNames";
- public SegmentReloadMessage(@Nonnull String tableNameWithType, @Nullable
String segmentName, boolean forceDownload) {
+ public SegmentReloadMessage(String tableNameWithType, List<String>
segmentNames, boolean forceDownload) {
Review Comment:
Shall we make `segmentNames` nullable and never empty? Passing empty list to
reload all segments can cause confusion. Also not sure if `getSegmentList()`
will return `null` in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
