walterddr commented on code in PR #9636:
URL: https://github.com/apache/pinot/pull/9636#discussion_r1003933172
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/ZkBasicAuthAccessControlFactory.java:
##########
@@ -101,8 +101,9 @@ public boolean hasAccess(RequesterIdentity
requesterIdentity, BrokerRequest brok
Optional<ZkBasicAuthPrincipal> principalOpt =
password2principal.entrySet().stream()
- .filter(entry -> BcryptUtils.checkpw(entry.getKey(),
entry.getValue().getPassword()))
- .map(u -> u.getValue()).filter(Objects::nonNull).findFirst();
+ .filter(entry ->
BcryptUtils.checkpwWithCache(entry.getKey(), entry.getValue().getPassword(),
+ _userCache.getUserPasswordAuthCache()))
+ .map(u ->
u.getValue()).filter(Objects::nonNull).findFirst();
Review Comment:
yeah please consolidate the usage into just one. this will make future
maintenance easier
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
