Jackie-Jiang commented on code in PR #9650:
URL: https://github.com/apache/pinot/pull/9650#discussion_r1004875008
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -484,18 +484,19 @@ public static String[] split(String input, String
delimiter) {
*/
@ScalarFunction
public static String[] split(String input, String delimiter, int limit) {
- return StringUtils.split(input, delimiter, limit);
+ return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
/**
+ * TODO: Revisit if index should be zero-based
Review Comment:
See the discussion under #9554. Added more comments to make it more clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
