This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 46aa54139f Fix server request sent delay to be non-negative (#9656)
46aa54139f is described below
commit 46aa54139fcbdab36851dcc2c4349d8ccfe3da79
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Tue Oct 25 16:33:42 2022 -0700
Fix server request sent delay to be non-negative (#9656)
---
.../org/apache/pinot/core/transport/AsyncQueryResponse.java | 2 +-
.../java/org/apache/pinot/core/transport/ServerChannels.java | 2 +-
.../java/org/apache/pinot/core/transport/ServerResponse.java | 10 +++-------
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java
b/pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java
index 6e9bafeb71..7924a9afdb 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java
@@ -128,7 +128,7 @@ public class AsyncQueryResponse implements QueryResponse {
_responseMap.get(serverRoutingInstance).markRequestSubmitted();
}
- void markRequestSent(ServerRoutingInstance serverRoutingInstance, long
requestSentLatencyMs) {
+ void markRequestSent(ServerRoutingInstance serverRoutingInstance, int
requestSentLatencyMs) {
_responseMap.get(serverRoutingInstance).markRequestSent(requestSentLatencyMs);
}
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
b/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
index 869e497486..f9ed68b08f 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerChannels.java
@@ -201,7 +201,7 @@ public class ServerChannels {
ServerRoutingInstance serverRoutingInstance, byte[] requestBytes) {
long startTimeMs = System.currentTimeMillis();
_channel.writeAndFlush(Unpooled.wrappedBuffer(requestBytes)).addListener(f -> {
- long requestSentLatencyMs = System.currentTimeMillis() - startTimeMs;
+ int requestSentLatencyMs = (int) (System.currentTimeMillis() -
startTimeMs);
_brokerMetrics.addTimedTableValue(rawTableName,
BrokerTimer.NETTY_CONNECTION_SEND_REQUEST_LATENCY,
requestSentLatencyMs, TimeUnit.MILLISECONDS);
asyncQueryResponse.markRequestSent(serverRoutingInstance,
requestSentLatencyMs);
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
b/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
index f669eb6909..79096d6059 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/transport/ServerResponse.java
@@ -30,7 +30,7 @@ import org.apache.pinot.common.datatable.DataTable;
public class ServerResponse {
private final long _startTimeMs;
private volatile long _submitRequestTimeMs;
- private volatile long _requestSentLatencyMs;
+ private volatile int _requestSentLatencyMs = -1;
private volatile long _receiveDataTableTimeMs;
private volatile DataTable _dataTable;
private volatile int _responseSize;
@@ -54,11 +54,7 @@ public class ServerResponse {
}
public int getRequestSentDelayMs() {
- if (_requestSentLatencyMs != 0) {
- return (int) _requestSentLatencyMs;
- } else {
- return -1;
- }
+ return _requestSentLatencyMs;
}
public int getResponseDelayMs() {
@@ -93,7 +89,7 @@ public class ServerResponse {
_submitRequestTimeMs = System.currentTimeMillis();
}
- void markRequestSent(long requestSentLatencyMs) {
+ void markRequestSent(int requestSentLatencyMs) {
_requestSentLatencyMs = requestSentLatencyMs;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
