jadami10 commented on code in PR #9648:
URL: https://github.com/apache/pinot/pull/9648#discussion_r1005881200
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/QueryResource.java:
##########
@@ -65,10 +67,20 @@ public class QueryResource {
@ApiResponse(code = 404, message = "Query not found running on the
server")
})
public String cancelQuery(
- @ApiParam(value = "QueryId as in the format of <brokerId>_<requestId>",
required = true) @PathParam("queryId")
- String queryId) {
+ @ApiParam(value = "QueryId as in the format of <brokerId>_<requestId> or
<brokerId>_<requestId>_(O|R)",
Review Comment:
nit: it might make more sense for consistency with other APIs to make the
offline/realtime part another optional API param. The default behavior has
always been to cancel both, so I don't think there's backwards compatibility to
worry about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
