walterddr commented on code in PR #9653:
URL: https://github.com/apache/pinot/pull/9653#discussion_r1007414374
##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTest.java:
##########
@@ -71,7 +77,9 @@ private List<Object[]> queryRunner(String sql) {
for (ServerInstance serverInstance :
queryPlan.getStageMetadataMap().get(stageId).getServerInstances()) {
DistributedStagePlan distributedStagePlan =
QueryDispatcher.constructDistributedStagePlan(queryPlan,
stageId, serverInstance);
- _servers.get(serverInstance).processQuery(distributedStagePlan,
requestMetadataMap);
+ EXECUTOR_SERVICE.submit(() -> {
Review Comment:
ah. this was me trying to simulate an actual submission of stage.
- previously they all run in the main test thread
- unit-test it doesn't include the query server, which suppose to run on a
remote service
so this is to simulate a simultaneous submission and execution without the
server / serde utils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
