klsince commented on code in PR #9668:
URL: https://github.com/apache/pinot/pull/9668#discussion_r1008354677


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/FetchContext.java:
##########
@@ -83,4 +83,8 @@ public String getSegmentName() {
   public Map<String, List<ColumnIndexType>> getColumnToIndexList() {
     return _columnToIndexList;
   }
+
+  public boolean isEmpty() {

Review Comment:
   as I'd like define the methods in FetchPlanner to always return non-null 
FetchContext, thus caller uses this method instead of `!=null`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to