walterddr commented on code in PR #9676:
URL: https://github.com/apache/pinot/pull/9676#discussion_r1008471955
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -183,34 +171,6 @@ private void consumeInputBlocks() {
}
}
- private AggregationFunction toAggregationFunction(RexExpression aggCall, int
aggregationFunctionInputRef) {
Review Comment:
no it is not used. the whole reason was i think previously i was using the
agg function to do the merge. but now that we decided to only support
SUM/COUNT/MIN/MAX it doesnt' necessary have to do that way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
