agavra opened a new pull request, #9701: URL: https://github.com/apache/pinot/pull/9701
I introduced the JMX bean for pinot version in #9578 but didn't realize that prometheus won't export metric names/labels that have `.` in them. This changes this so that the version replaces all `.` and `-` with `_`. Tested it by hooking it up to the prometheus agent and checking http://localhost:8008/metrics: ``` # HELP pinot_controller_version Attribute exposed for management "org.apache.pinot.common.metrics":name="pinot.controller.version.0_12_0_SNAPSHOT",type="ControllerMetrics",attribute=Value # TYPE pinot_controller_version untyped pinot_controller_version{version="0_12_0_SNAPSHOT",} 1.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
